Add Throughput and SLO Metrics with SLOConfig in Query Frontend#2008
Merged
joe-elliott merged 18 commits intografana:mainfrom Mar 28, 2023
Merged
Add Throughput and SLO Metrics with SLOConfig in Query Frontend#2008joe-elliott merged 18 commits intografana:mainfrom
joe-elliott merged 18 commits intografana:mainfrom
Conversation
electron0zero
requested review from
annanay25,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding documentation for these changes. My only comment was to add some missing periods.
electron0zero
force-pushed
the
query_bytes
branch
from
2dba23d to
b251f27
Compare
joe-elliott
reviewed
Feb 7, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
overall nice work! handful of thoughts that i'm looking for your opinion on.
electron0zero
force-pushed
the
query_bytes
branch
from
b251f27 to
249b145
Compare
electron0zero
commented
Feb 9, 2023
mdisibio
reviewed
Feb 10, 2023
mdisibio
reviewed
Feb 28, 2023
electron0zero
force-pushed
the
query_bytes
branch
from
3dd641e to
8697ff9
Compare
joe-elliott
reviewed
Mar 27, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
two small changes, but looks great!
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
electron0zero
force-pushed
the
query_bytes
branch
from
8697ff9 to
a279527
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Expose Throughput (for search only) and SLO Metrics, and add config in Query Frontend to configure SLOs
Note: this doesn't work with TraceQL yet because we are not sending SearchMetrics from TraceQL query execution, it will work after we start returning SearchMetrics from TraceQL query execution
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]