span id to hex#2062
Conversation
joe-elliott
left a comment
There was a problem hiding this comment.
This looks good. One last thing! Add a changelog entry then we'll merge and backport to 2.0.1
|
@joe-elliott One last question, extra logic would have to be added to this I believe but what happens if the span id has leading zeroes and it is longer than 16 characters? Still no trimming? |
since we're in "shouldn't happen" territory i'm fine with anything that:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2062-to-release-v2.0 origin/release-v2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 2d50f21918c81a433e62b6f9b759ca7b98ed7482
# Push it to GitHub
git push --set-upstream origin backport-2062-to-release-v2.0
git switch main
# Remove the local backport branch
git branch -D backport-2062-to-release-v2.0Then, create a pull request where the |
* span id to hex * logic * simplify * fmt * update test * what is logic * changelog (cherry picked from commit 2d50f21)
What this PR does: stop removing leading zeroes in span ids
Which issue(s) this PR fixes:
Fixes #2060
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]