Remove v2 search#2159
Merged
joe-elliott merged 24 commits intografana:mainfrom Mar 9, 2023
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
knylander-grafana,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Collaborator
Author
|
@knylander-grafana pushed docs changes |
3 tasks
zalegrala
approved these changes
Mar 9, 2023
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
Nice work, I love to see the quick turn around here.
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for updating the docs! I've made a few suggestions.
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
mdisibio
pushed a commit
to mdisibio/tempo
that referenced
this pull request
Apr 18, 2023
* o7 old search Signed-off-by: Joe Elliott <number101010@gmail.com> * everything except instance_search Signed-off-by: Joe Elliott <number101010@gmail.com> * deleting stuff like it's my job Signed-off-by: Joe Elliott <number101010@gmail.com> * removed some overrides Signed-off-by: Joe Elliott <number101010@gmail.com> * moar Signed-off-by: Joe Elliott <number101010@gmail.com> * test cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * vendor cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * carnage Signed-off-by: Joe Elliott <number101010@gmail.com> * o7 pipeline. you served us well Signed-off-by: Joe Elliott <number101010@gmail.com> * more Signed-off-by: Joe Elliott <number101010@gmail.com> * config Signed-off-by: Joe Elliott <number101010@gmail.com> * Changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * patch up integration tests Signed-off-by: Joe Elliott <number101010@gmail.com> * move metrics check Signed-off-by: Joe Elliott <number101010@gmail.com> * remove check Signed-off-by: Joe Elliott <number101010@gmail.com> * remove unnecessary check Signed-off-by: Joe Elliott <number101010@gmail.com> * already flushed Signed-off-by: Joe Elliott <number101010@gmail.com> * tests pass Signed-off-by: Joe Elliott <number101010@gmail.com> * update docs Signed-off-by: Joe Elliott <number101010@gmail.com> * Update docs/sources/tempo/configuration/parquet.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/tempo/operations/backend_search.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
As announced with the release of 2.0 v2 search will be removed for 2.1. This code got quite complicated and removing it will allow us to more confidently move forward with building TraceQL and additional features.
Which issue(s) this PR fixes:
Fixes #1899
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]