Skip to content

Synchronous iterator #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdisibio merged 24 commits into from
Apr 25, 2023
Merged

Synchronous iterator #2165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
eb40bfc
Mostly working synchronous iterator and tests
mdisibio Mar 2, 2023
421c4f2
Fully working version - passing all tempodb/traceql tests
mdisibio Mar 3, 2023
01feecd
Performance improvements
mdisibio Mar 3, 2023
b681e07
Memmory optimization, don't alloc buffer until needed and use pooling
mdisibio Mar 3, 2023
45aa88c
Swap vParquet to the synciterator and a few test tweaks
mdisibio Mar 3, 2023
a3c033d
Merge branch 'main' into sync-iterator
joe-elliott Mar 7, 2023
05bda27
SyncIterator -> Stringer
joe-elliott Mar 7, 2023
deced69
Use dedicated pool/buffers for sync iterator
mdisibio Mar 8, 2023
36f0d67
Micro-optimization to pass value by address
mdisibio Mar 8, 2023
0f91b31
Fix bug where synciterator didn't fully exit after exhausting pages i…
mdisibio Apr 18, 2023
542ad33
Gate parquet synciterator behind an env var
mdisibio Apr 18, 2023
0688f56
Fix bug where synciterator current row number wasn't updated when ski…
mdisibio Apr 18, 2023
9e9db00
Merge branch 'main' into sync-iterator
mdisibio Apr 18, 2023
d4518f3
Fix bug where synciterator skipped a page when it shouldn't have
mdisibio Apr 18, 2023
3145938
lint
mdisibio Apr 19, 2023
4d440c7
lint
mdisibio Apr 19, 2023
2f00482
Comments and cleanup
mdisibio Apr 19, 2023
4589863
Fix OrPredicate.String nil handling
mdisibio Apr 19, 2023
17bd52a
Update vparquet2 and changelog
mdisibio Apr 20, 2023
477de6a
Apply test updates to vparquet2
mdisibio Apr 24, 2023
ff155e5
Fix mergeSpanSetIterator to close sub-iterators as they become exhaus…
mdisibio Apr 24, 2023
a610414
Add instrumentation to SyncIterator
mdisibio Apr 24, 2023
9b2c946
Merge branch 'main' into sync-iterator
mdisibio Apr 24, 2023
75d336e
lint
mdisibio Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* [ENHANCEMENT] Ability to toggle off latency or count metrics in metrics-generator [#2070](https://github.com/grafana/tempo/pull/2070) (@AlexDHoffer)
* [ENHANCEMENT] Extend `/flush` to support flushing a single tenant [#2260](https://github.com/grafana/tempo/pull/2260) (@kvrhdn)
* [ENHANCEMENT] Add override to limit number of blocks inspected in tag value search [#2358](https://github.com/grafana/tempo/pull/2358) (@mapno)
* [ENHANCEMENT] Add synchronous read mode to vParquet and vParquet2 optionally enabled by env vars [#2165](https://github.com/grafana/tempo/pull/2165) (@mdisibio)
* [BUGFIX] tempodb integer divide by zero error [#2167](https://github.com/grafana/tempo/issues/2167) (@kroksys)

## v2.1.0-rc.0 / 2023-04-12
Expand Down
Loading