Add context to Read span#2220
Merged
knylander-grafana merged 5 commits intografana:mainfrom Mar 17, 2023
ie-pham:jpham/trace
Merged
Add context to Read span#2220knylander-grafana merged 5 commits intografana:mainfrom ie-pham:jpham/trace
knylander-grafana merged 5 commits intografana:mainfrom
ie-pham:jpham/trace
Conversation
ie-pham
requested review from
annanay25,
joe-elliott,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Mar 16, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
looks good! give us a changelog entry :)
after merging you may want to keep an eye on internal tempo to make sure that we don't suddenly have tons of single span write traces
knylander-grafana
approved these changes
Mar 17, 2023
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding the changelog entry!
mdisibio
pushed a commit
to mdisibio/tempo
that referenced
this pull request
Apr 18, 2023
* add context to read * typo * fmt * oops * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Renamed some spans to match the cloud provider and started a trace around polling tenant index to add context to the "Read" traces.
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/tempo-squad/issues/193
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]