Don't keep file and reader around in backendBlock#2273
Merged
joe-elliott merged 1 commit intografana:mainfrom Mar 30, 2023
Merged
Don't keep file and reader around in backendBlock#2273joe-elliott merged 1 commit intografana:mainfrom
joe-elliott merged 1 commit intografana:mainfrom
Conversation
electron0zero
requested review from
annanay25,
joe-elliott,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Mar 29, 2023
electron0zero
added a commit
to electron0zero/tempo
that referenced
this pull request
Apr 6, 2023
3 tasks
electron0zero
added a commit
to electron0zero/tempo
that referenced
this pull request
Apr 7, 2023
electron0zero
added a commit
to electron0zero/tempo
that referenced
this pull request
Apr 11, 2023
joe-elliott
pushed a commit
that referenced
this pull request
Apr 11, 2023
* WIP * first pass at walReaderAt * use io.ReaderAt instead of os.File * Add tests * cleanup todo * read TotalBytesRead during callback to get accurate size after iteration * sometimes we read whole block * sync vparquet changes with vparquet2, also includes #2273 changes * Make walReaderAt private and add BytesRead method * Add BytesRead on BackendReaderAt * fix lint * Make TotalBytesRead private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
We are saving file and reader in backendBlock, but are never using them. removing them to save some memory
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]