TraceQL: Support negative values on aggregates#2289
Merged
joe-elliott merged 3 commits intografana:mainfrom Mar 31, 2023
Merged
TraceQL: Support negative values on aggregates#2289joe-elliott merged 3 commits intografana:mainfrom
joe-elliott merged 3 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
Contributor
|
will this update impact how a user can create a query? If so, should we have an example of it in the TraceQL doc? |
Collaborator
Author
it just fixes a bug. nothing to update |
zalegrala
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for negative values in aggregate filters.
Which issue(s) this PR fixes:
Fixes #2182
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]