Skip to content

Supports ranger operators for strings in TraceQL#2321

Merged
ie-pham merged 8 commits intografana:mainfrom
ie-pham:jp/rangeoperator
Apr 21, 2023
Merged

Supports ranger operators for strings in TraceQL#2321
ie-pham merged 8 commits intografana:mainfrom
ie-pham:jp/rangeoperator

Conversation

@ie-pham
Copy link
Copy Markdown
Contributor

@ie-pham ie-pham commented Apr 10, 2023

What this PR does: Supports ranger operators for strings in TraceQL

Which issue(s) this PR fixes:
Fixes #2181

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@knylander-grafana
Copy link
Copy Markdown
Contributor

@ie-pham Do we need to update the doc for ranger operators?

@ie-pham ie-pham changed the title Supports ranger operators for strings in TraceQL [wip]Supports ranger operators for strings in TraceQL Apr 11, 2023
@ie-pham ie-pham changed the title [wip]Supports ranger operators for strings in TraceQL Supports ranger operators for strings in TraceQL Apr 18, 2023
@ie-pham
Copy link
Copy Markdown
Contributor Author

ie-pham commented Apr 18, 2023

@mdisibio not sure how to do byte compare because it needs match the query type?

Copy link
Copy Markdown
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! Doc changes look good.

Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

Comment thread CHANGELOG.md Outdated
Comment thread docs/sources/tempo/traceql/_index.md Outdated
@ie-pham ie-pham merged commit c6b269c into grafana:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TraceQL] Support range operators for strings

3 participants