Arbitrary span duration metrics from any TraceQL-compatible block#2418
Merged
mdisibio merged 4 commits intografana:mainfrom May 4, 2023
Merged
Arbitrary span duration metrics from any TraceQL-compatible block#2418mdisibio merged 4 commits intografana:mainfrom
mdisibio merged 4 commits intografana:mainfrom
Conversation
mdisibio
requested review from
annanay25,
joe-elliott,
mapno,
yvrhdn and
zalegrala
as code owners
zalegrala
approved these changes
May 4, 2023
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
Looks like a great start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR is part of a wider initiative to perform on-demand metrics calculations. It adds a new package
traceqlmetricswhich can get the metrics from anySpansetFetchergiven a traceql query and an identifier to group on. I.e. calculate the duration p90 for the query{ .service.name="a" && .cluster="prod"}grouped byspan.customer_id. API and integration with #2368 will follow in a separate PR.Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]