Add new metrics API to generator and protobuf definition#2424
Merged
mdisibio merged 31 commits intografana:mainfrom May 12, 2023
Merged
Add new metrics API to generator and protobuf definition#2424mdisibio merged 31 commits intografana:mainfrom
mdisibio merged 31 commits intografana:mainfrom
Conversation
zalegrala
changed the title
zalegrala
force-pushed
the
generatorSpanStats
branch
from
a599b13 to
6f6ee6c
Compare
zalegrala
commented
May 4, 2023
zalegrala
commented
May 4, 2023
zalegrala
force-pushed
the
generatorSpanStats
branch
3 times, most recently
from
17f64e3 to
bc1748e
Compare
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
mdisibio
reviewed
May 12, 2023
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Looking great. Left a few nits.
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
…by the querier Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
zalegrala
force-pushed
the
generatorSpanStats
branch
from
a3bd981 to
76a606f
Compare
mdisibio
approved these changes
May 12, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a new metrics API to the generator and protobuf definition.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]