[ENHANCEMENT] log client ip to help identify which client is no org id#2436
Merged
mapno merged 6 commits intografana:mainfrom May 23, 2023
Merged
[ENHANCEMENT] log client ip to help identify which client is no org id#2436mapno merged 6 commits intografana:mainfrom
mapno merged 6 commits intografana:mainfrom
Conversation
Log client ip to help identify which client is no org id
[ENHANCEMENT] log client ip to help identify which client is no org id
Komey
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
|
|
electron0zero
approved these changes
May 8, 2023
mapno
reviewed
May 16, 2023
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
LGTM, but the panic needs to be fixed.
| if len(orgIDs) == 0 { | ||
| log.Logger.Log("msg", "failed to extract org id from both grpc and HTTP", "err", err) | ||
| log.Logger.Log("msg", "failed to extract org id from both grpc and HTTP", | ||
| "err", err, "client", info.Addr.String()) |
Contributor
There was a problem hiding this comment.
This is causing a panic when info.Addr == nil. You need to add a check for that.
Contributor
Author
Contributor
There was a problem hiding this comment.
net.Addr is an interface, so it panics when undefined. See example https://go.dev/play/p/dx6a1BYB16J.
Contributor
Author
There was a problem hiding this comment.
@mapno Thanks for the correction, the panics has been fixed
mapno
approved these changes
May 23, 2023
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
add log for client ip to help identify which client is no org id
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]