Regex tweak#2484
Merged
mdisibio merged 3 commits intografana:mainfrom May 17, 2023
Merged
Conversation
mdisibio
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
stoewer,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
May 17, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
nice. i didn't know about that zero alloc optimization on maps
| ctx := context.TODO() | ||
| tenantID := "1" | ||
| blockID := uuid.MustParse("149e41d2-cc4d-4f71-b355-3377eabc94c8") | ||
| blockID := uuid.MustParse("2968a567-5873-4e4c-b3cb-21c106c6714b") |
Member
There was a problem hiding this comment.
149e41d2-cc4d-4f71-b355-3377eabc94c8 is joe's fav uuid 😆
joe-elliott
approved these changes
May 17, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
nice. i didn't know about that zero alloc optimization on maps
Contributor
Author
Neither did I 💡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Makes regex predicate faster. Particularly the case where there are found matches because of all the map access.
Tweak originally discussed #2410 (comment)
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]