[TraceQL] Add trace level intrinsics#2503
Merged
joe-elliott merged 16 commits intografana:mainfrom May 25, 2023
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
electron0zero,
ie-pham,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
Collaborator
Author
|
async iterator benchmarks are showing an unfortunate increase in memory usage: sync iterator benchmarks are seeing a small, but expected increase in memory usage: |
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
This was referenced May 24, 2023
mdisibio
reviewed
May 24, 2023
| case columnPathDurationNanos: | ||
| finalSpanset.DurationNanos = e.Value.Uint64() | ||
| initAttrs() | ||
| traceAttrs[traceql.NewIntrinsic(traceql.IntrinsicTraceDuration)] = traceql.NewStaticDuration(time.Duration(finalSpanset.DurationNanos)) |
Contributor
There was a problem hiding this comment.
A few thoughts on this:
- This copies the trace-level attributes to the span even if they aren't part of the query, just retrieved as basic metadata. Do we need to do that?
- This is likely the source of increased mem usage. The local map var could be a reusable buffer on the collector.
Collaborator
Author
There was a problem hiding this comment.
At the fetch layer can we tell the difference? My thought was this only really negatively impacts the second pass which is significantly less important than the first pass. I figured handling different cases would not be worth the code grossness.
Good call on the reusable map.
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding docs. The updates look good. I've added a suggestion for admonition shortcodes.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
mdisibio
reviewed
May 25, 2023
| attribute.Intrinsic == IntrinsicDuration || | ||
| attribute.Intrinsic == IntrinsicTraceDuration || | ||
| attribute.Intrinsic == IntrinsicTraceRootService || | ||
| attribute.Intrinsic == IntrinsicTraceRootSpan { |
Contributor
There was a problem hiding this comment.
👍 Ah ok I missed this before. We could probably simplify the Span interface and put the intrinsics just in the map and not dedicated fields in the future.
mdisibio
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds trace level intrinsics:
traceDuration,rootServiceNameandrootName.Which issue(s) this PR fixes:
This is not quite the same as adding a scope but it does address the major needs in #1989
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]