FIX-699: Add capability to completely flush on shutdown#2538
Merged
mapno merged 1 commit intografana:mainfrom Jun 7, 2023
Merged
FIX-699: Add capability to completely flush on shutdown#2538mapno merged 1 commit intografana:mainfrom
mapno merged 1 commit intografana:mainfrom
Conversation
mghildiy
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Jun 3, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Looks great! Thanks for digging into this. Please add a changelog entry and we'll merge.
Contributor
Author
I have already added it in CHANGELOG.md. |
Collaborator
Not sure how I missed that. Thanks! |
Contributor
Author
|
TestInstanceSearchDoesNotRace failed. I checked its code, and I see several concurrent functions. May be thats making it flaky. |
Collaborator
Yeah. It's meant to test for concurrency issues. The issue that is tripping CI it is documented here: #2534 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Ingester] Add ability to completely flush on shutdown
Which issue(s) this PR fixes:
Fixes #699
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]