Fix target_info labels#2546
Merged
ie-pham merged 13 commits intografana:mainfrom Jun 13, 2023
ie-pham:jp/fix_gauge
Merged
Conversation
ie-pham
requested review from
annanay25,
electron0zero,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
zalegrala
reviewed
Jun 8, 2023
|
|
||
| for _, s := range g.series { | ||
| t := time.UnixMilli(timeMs) | ||
| lbls := make(labels.Labels, 1+len(externalLabels)+len(s.labels.names)) |
Contributor
There was a problem hiding this comment.
We might want to keep the allocations outside of the loop. I think I saw a Reset() method on the lb object that might empty this out.
Contributor
Author
|
Tested in dev, there are now only 2 metrics instead of 10+ (2 because there are two m-gen instance) |
mapno
reviewed
Jun 9, 2023
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
I think it's missing a test to ensure the bug is fixed. Otherwise, LGTM
Contributor
Author
|
added test and made sure they failed before the fix and passed after the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: The
labelsvariable in the gauge & countercollectMetricsfunction was created outside the for loop and so we were constantly adding labels to metrics after metrics.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]