Queriers: Implement RBAC on external queriers#2593
Merged
joe-elliott merged 13 commits intografana:mainfrom Jul 19, 2023
Merged
Queriers: Implement RBAC on external queriers#2593joe-elliott merged 13 commits intografana:mainfrom
joe-elliott merged 13 commits intografana:mainfrom
Conversation
modulitos
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
modulitos
force-pushed
the
2477-external-querier
branch
3 times, most recently
from
f0d5e15 to
42abc1b
Compare
modulitos
commented
Jun 26, 2023
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding some doc content. When we add more support, it would be great to add a configuration page with information about use cases, benefits, etc.
joe-elliott
reviewed
Jun 26, 2023
knylander-grafana
removed
the
type/docs
modulitos
force-pushed
the
2477-external-querier
branch
2 times, most recently
from
c20bdd5 to
5cb0fd8
Compare
modulitos
commented
Jul 6, 2023
modulitos
force-pushed
the
2477-external-querier
branch
2 times, most recently
from
5881a2d to
0827d56
Compare
joe-elliott
reviewed
Jul 10, 2023
modulitos
force-pushed
the
2477-external-querier
branch
2 times, most recently
from
23623e4 to
a328a02
Compare
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
Signed-off-by: modulitos <hi@modulitos.com>
modulitos
force-pushed
the
2477-external-querier
branch
from
a328a02 to
fc0367f
Compare
Signed-off-by: modulitos <hi@modulitos.com>
joe-elliott
approved these changes
Jul 19, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
great work! appreciate this contribution. adds a nice authentication option for GCR and starts laying the groundwork for additional configuration per backend.
3 tasks
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds RBAC support when querying the external endpoints. It adds an "external client" struct to encapsulate the concerns around sending remote requests to an external endpoint, which makes it easier to inject RBAC behavior into that struct.
It only supports RBAC on CloudRun, but adding Lambda support should be an easy followup. I also did a red/green smoke test using a CloudRun backend, and it's behaving as expected.
Which issue(s) this PR fixes:
Resolves #2477
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]