fix: record TraceByIDSLO for 404 response#2611
Merged
electron0zero merged 1 commit intografana:mainfrom Jul 5, 2023
Merged
Conversation
electron0zero
requested review from
annanay25,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
Contributor
|
Hello @mapno!
Please, if the current pull request addresses a bug fix, label it with the |
mapno
added
type/bug
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
(cherry picked from commit d6544e8)
mapno
pushed a commit
that referenced
this pull request
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
404 is valid response for TraceByID search, and should be recorded in SLOs.