[vparquet3] Add command to tempo-cli to analyse blocks for dedicated columns#2622
[vparquet3] Add command to tempo-cli to analyse blocks for dedicated columns#2622stoewer merged 17 commits intografana:mainfrom
Conversation
mapno
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
| case vparquet.VersionString: | ||
| return vparquet.FieldSpanAttrKey, vparquetSpanAttrs | ||
| case vparquet2.VersionString: | ||
| return vparquet2.FieldSpanAttrKey, vparquet2SpanAttrs | ||
| } |
There was a problem hiding this comment.
I assume this will be vParquet2 and vParquet3 as soon as vParquet3 is realeased?
|
|
||
| func newBackendBlock(meta *backend.BlockMeta, r backend.Reader) *backendBlock { | ||
| return &backendBlock{ | ||
| func NewBackendBlock(meta *backend.BlockMeta, r backend.Reader) *BackendBlock { |
There was a problem hiding this comment.
I'm wondering whether there is an alternative to making this function and BackendBlock public. Maybe the CLI could have a thin wrapper around backend.ContextReader that implements an io.ReaderAt that can be passed into parquet.OpenFile()
There was a problem hiding this comment.
Used NewBackendReaderAt() and passed the reader to parquet.OpenFile() instead. No need to export BackendBlock nor any of its methods. Nice call.
|
|
||
| ## Analyse blocks | ||
| Analyses all blocks in a given time range and outputs a summary of the blocks' generic attributes. | ||
| It's of particular use when trying to determine what attributes to configure for dedicated columns in vParquet3. |
There was a problem hiding this comment.
Maybe link to the dedicated columns page (PR#2664)?
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Approving the doc portion of the PR. Thank you for adding doc!
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
3 participants
What this PR does:
NOTE: Depends on
vparquet3being merged tomainAdds two new methods to
tempo-clito analyse parquet blocks and output summaries of generic attribute columns:Analyse block
Analyses a block and outputs a summary of the block's generic attributes.
It's of particular use when trying to determine what attributes to configure for dedicated columns in vParquet3.
Arguments:
tenant-idThe tenant ID. Usesingle-tenantfor single tenant setups.block-idThe block ID as UUID string.Options:
--num-attr <value>Number of attributes to output (default: 10)Example:
Analyse blocks
Analyses all blocks in a given time range and outputs a summary of the blocks' generic attributes. It's of particular use when trying to determine what attributes to configure for dedicated columns in vParquet3.Arguments:
tenant-idThe tenant ID. Usesingle-tenantfor single tenant setups.Options:
--num-attr <value>Number of attributes to output (default: 10)--min-compaction-level <value>Minimum compaction level to include in the analysis (default: 3)--max-blocks <value>Maximum number of blocks to analyse (default: 10)Example:
Which issue(s) this PR fixes:
Fixes #2630
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]