Delay logging config warnings until the logger has been initialized#2645
Merged
yvrhdn merged 2 commits intografana:mainfrom Jul 13, 2023
Merged
Delay logging config warnings until the logger has been initialized#2645yvrhdn merged 2 commits intografana:mainfrom
yvrhdn merged 2 commits intografana:mainfrom
Conversation
Contributor
Author
|
Alternative solutions:
|
joe-elliott
approved these changes
Jul 12, 2023
Collaborator
joe-elliott
left a comment
There was a problem hiding this comment.
i swear i've seen it correctly print warnings before. /shrug
electron0zero
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
While adding config warnings in #2543 I noticed the warnings never got printed. Because we print the warnings while loading the configuration, we log them using the default NoopLogger...
This PR holds on to the warnings until we initialized the logger and can correctly log them.
End result:
Which issue(s) this PR fixes:
Fixes #Checklist
Tests updatedDocumentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]