Skip to content

Add the /api/status/buildinfo endpoint#2702

Merged
mapno merged 9 commits intomainfrom
buildinfo-endpoint
Jul 27, 2023
Merged

Add the /api/status/buildinfo endpoint#2702
mapno merged 9 commits intomainfrom
buildinfo-endpoint

Conversation

@fabrizio-grafana
Copy link
Copy Markdown
Contributor

@fabrizio-grafana fabrizio-grafana commented Jul 26, 2023

What this PR does:
Add a new /api/status/buildinfo endpoint, as discussed in the associated issue.

Which issue this PR fixes:
Fixes #2387

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@fabrizio-grafana fabrizio-grafana changed the title Add new endpoint Add the /api/status/buildinfo endpoint Jul 26, 2023
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very thorough PR. thank you. two nits and it looks like you need to sign the CLA.

Comment thread CHANGELOG.md Outdated
Comment thread cmd/tempo/app/app.go Outdated
Copy link
Copy Markdown
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding docs. Doc changes look good.

Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a conflict in the e2e test, but other than that this looks good. If you can resolve we will merge.

Thanks!

@mapno mapno merged commit 34bcfe7 into main Jul 27, 2023
@mapno mapno deleted the buildinfo-endpoint branch July 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend /status to better serve frontends

5 participants