fix2640: Distributor refactoring to assert ingestion rate limits as early as possible#2703
Merged
joe-elliott merged 2 commits intografana:mainfrom Jul 27, 2023
Merged
fix2640: Distributor refactoring to assert ingestion rate limits as early as possible#2703joe-elliott merged 2 commits intografana:mainfrom
joe-elliott merged 2 commits intografana:mainfrom
Conversation
mghildiy
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
mghildiy
force-pushed
the
fix2640
branch
2 times, most recently
from
3e0a10b to
4a8e28f
Compare
joe-elliott
reviewed
Jul 26, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
nice fix! thanks.
two easy comments/changes.
Collaborator
|
looks like we're all fighting for space in the 2.3 changelog :). If you can resolve that conflict, I will merge. |
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Refactor distributor to ensure that rate limits are checked before other costly operations are done
Which issue(s) this PR fixes:
Fixes #2640
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]