Metrics Summary: fix panic edge case#2738
Merged
mdisibio merged 2 commits intografana:mainfrom Aug 1, 2023
Merged
Conversation
mdisibio
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
stoewer,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Jul 31, 2023
zalegrala
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes a panic for very large uint64s. This was seen in the wild and my best guess is its from calculating
duration = endTime - startTimewhen endTime is less than startTime (leading to unsigned wrap-around). So this doesn't address the root cause, per se, but prevents the panic and bad data will be visible.Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]