Cliquery

[ie-pham]

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

• Tests updated
• Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[joe-elliott]

the root span is not always the first. as you're iterating through all the spans below look for one with no parent span id

[joe-elliott]

instead of grabbing this first span like this we should init firstStartTime/lastEndTime/rootSpan/rootResource to better first values. something like this diff:

@@ -4,11 +4,14 @@ import (
        "bytes"
        "context"
        "fmt"
+       "math"
        "sort"
 
        "github.com/gogo/protobuf/jsonpb"
 
        "github.com/grafana/tempo/pkg/model/trace"
+       v1resource "github.com/grafana/tempo/pkg/tempopb/resource/v1"
+       v1 "github.com/grafana/tempo/pkg/tempopb/trace/v1"
        "github.com/grafana/tempo/pkg/util"
 )
 
@@ -47,15 +50,16 @@ func (cmd *queryBlocksSummaryCmd) Run(ctx *globalOptions) error {
        }
 
        combinedTrace, _ := combiner.Result()
+
+       var rootSpan *v1.Span
+       var rootSpanResource *v1resource.Resource
        size := 0
        spanCount := 0
-       firstStartTime := combinedTrace.Batches[0].ScopeSpans[0].Spans[0].StartTimeUnixNano
-       lastEndTime := combinedTrace.Batches[0].ScopeSpans[0].Spans[0].EndTimeUnixNano
-       rootSpan := combinedTrace.Batches[0].ScopeSpans[0].Spans[0]
-       rootSpanResource := combinedTrace.Batches[0].Resource
+       firstStartTime := uint64(math.MaxUint64)
+       lastEndTime := uint64(0)
+
        rootServiceName := ""
        serviceNameMap := make(map[string]int)
-
        for _, b := range combinedTrace.Batches {
                size += b.Size()
                for _, attr := range b.Resource.Attributes {

[joe-elliott]

i would probably just put all of the key/value pairs in a slice and sort it. it won't be as efficient, but it will be clearer and this CLI command doesn't need to be super efficient.

[joe-elliott]

heading the right way. we need:

• changelog
• docs

i also don't like the command name, but it does nicely match the query blocks command.

[joe-elliott]

instead of grabbing this first span like this we should init firstStartTime/lastEndTime/rootSpan/rootResource to better first values. something like this diff:

@@ -4,11 +4,14 @@ import (
        "bytes"
        "context"
        "fmt"
+       "math"
        "sort"
 
        "github.com/gogo/protobuf/jsonpb"
 
        "github.com/grafana/tempo/pkg/model/trace"
+       v1resource "github.com/grafana/tempo/pkg/tempopb/resource/v1"
+       v1 "github.com/grafana/tempo/pkg/tempopb/trace/v1"
        "github.com/grafana/tempo/pkg/util"
 )
 
@@ -47,15 +50,16 @@ func (cmd *queryBlocksSummaryCmd) Run(ctx *globalOptions) error {
        }
 
        combinedTrace, _ := combiner.Result()
+
+       var rootSpan *v1.Span
+       var rootSpanResource *v1resource.Resource
        size := 0
        spanCount := 0
-       firstStartTime := combinedTrace.Batches[0].ScopeSpans[0].Spans[0].StartTimeUnixNano
-       lastEndTime := combinedTrace.Batches[0].ScopeSpans[0].Spans[0].EndTimeUnixNano
-       rootSpan := combinedTrace.Batches[0].ScopeSpans[0].Spans[0]
-       rootSpanResource := combinedTrace.Batches[0].Resource
+       firstStartTime := uint64(math.MaxUint64)
+       lastEndTime := uint64(0)
+
        rootServiceName := ""
        serviceNameMap := make(map[string]int)
-
        for _, b := range combinedTrace.Batches {
                size += b.Size()
                for _, attr := range b.Resource.Attributes {

[knylander-grafana]

@ie-pham This looks like a useful tool. Should we add some doc for this?

[joe-elliott]

what if length is less than 5? i think this panics

[ie-pham]

since we are iterating through the actual list of service names using its length (or if it's longer than 5 use 5), even if it's less than 3, we wouldn't get to out of range. It just prints out a weird looking array with extra spaces

[a b c ]