Add span metrics filter policies to user-configurable overrides api#2906
Merged
yvrhdn merged 1 commit intografana:mainfrom Sep 8, 2023
Merged
Add span metrics filter policies to user-configurable overrides api#2906yvrhdn merged 1 commit intografana:mainfrom
yvrhdn merged 1 commit intografana:mainfrom
Conversation
Signed-off-by: Robbie Lankford <robert.lankford@grafana.com>
bdab166 to
02aa7a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extends the user-configurable overrides added in #2543 with spanmetrics filter policies override.
New JSON Payload example:
{ "forwarders": [], "metrics_generator": { "processors": [ "service-graphs", "span-metrics" ], "disable_collection": false, "processor": { "service_graphs": { "dimensions": [ "service.namespace" ], "enable_client_server_prefix": true, "peer_attributes": [ "peer.service", "db.name", "db.system", "db.url" ] }, "span_metrics": { "dimensions": [ "service.namespace" ], "enable_target_info": true, "filter_policies": [ { "include": { "match_type": "strict", "attributes": [ { "key": "span.kind", "value": "SPAN_KIND_SERVER" } ] } }, { "include": { "match_type": "strict", "attributes": [ { "key": "span.kind", "value": "SPAN_KIND_CLIENT" } ] } } ] } } } }Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]