TraceQL: Experimental "not structural" operators#2993
Merged
joe-elliott merged 14 commits intografana:mainfrom Oct 10, 2023
Merged
TraceQL: Experimental "not structural" operators#2993joe-elliott merged 14 commits intografana:mainfrom
joe-elliott merged 14 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
electron0zero,
ie-pham,
knylander-grafana,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
changed the title
| { span.http.url = "/path/of/api" } >> { span.db.name = "db-shard-001" } | ||
| ``` | ||
|
|
||
| ### Experimental Structural |
Contributor
There was a problem hiding this comment.
I added the standard wording that we use for an experimental feature or capability. What do you think?
Suggested change
| ### Experimental Structural | |
| ### Experimental structural | |
| {{% admonition type="warning" %}} | |
| These experimental spanset operators is an [experimental feature](/docs/release-life-cycle/). Engineering and on-call support is not available. Documentation is either limited or not provided outside of code comments. No SLA is provided. | |
| {{% /admonition %}} |
Collaborator
Author
There was a problem hiding this comment.
I don't mind adding a warning, but these are OSS docs. I don't think it makes sense to talk about SLAs or support.
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding documentation with examples! Awesome.
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
mdisibio
approved these changes
Oct 10, 2023
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Awesome addition, good cleanup and tests. Left a few small thoughts, but going ahead and approving.
yvrhdn
pushed a commit
that referenced
this pull request
Oct 11, 2023
* disable parquet trace index by default (#2990) * Update parquet-go to include page header caching fix (#2981) * Tempo: add dedicated columns to block analyze (#2994) * adde dedicated columns to block analysize Signed-off-by: Joe Elliott <number101010@gmail.com> * load Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> * Bump jaeger-query docker image to 1.50 (#2998) Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * TraceQL: Experimental "not structural" operators (#2993) * first pass add Signed-off-by: Joe Elliott <number101010@gmail.com> * fix and tests Signed-off-by: Joe Elliott <number101010@gmail.com> * removed ancestor/descendant due to parsing issues Signed-off-by: Joe Elliott <number101010@gmail.com> * added tempodb lvl tests Signed-off-by: Joe Elliott <number101010@gmail.com> * parse tests Signed-off-by: Joe Elliott <number101010@gmail.com> * consolidated code Signed-off-by: Joe Elliott <number101010@gmail.com> * tests Signed-off-by: Joe Elliott <number101010@gmail.com> * docs Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * not ancestor/descendant Signed-off-by: Joe Elliott <number101010@gmail.com> * tempodb tests and docs Signed-off-by: Joe Elliott <number101010@gmail.com> * remove load Signed-off-by: Joe Elliott <number101010@gmail.com> * Apply suggestions from code review Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update dskit (#3002) * Update dskit * fmt * Update prometheus to latest release v2.47.1 (c4d1a8b) (#3001) * Update prometheus to latest release v2.47.1 (c4d1a8b) I ran ``` go get github.com/prometheus/prometheus@c4d1a8b ``` And fixed any compilation issues * Checkin .test files from prometheus * go mod tidy * More fixes * Final set of fixes? 🤞 * Lint --------- Co-authored-by: Mario <mariorvinas@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Signed-off-by: Pavol Loffay <p.loffay@gmail.com> Co-authored-by: Martin Disibio <martin.disibio@grafana.com> Co-authored-by: Mario <mariorvinas@gmail.com> Co-authored-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Pavol Loffay <p.loffay@gmail.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
sonisr
pushed a commit
to sonisr/tempo
that referenced
this pull request
Oct 11, 2023
* first pass add Signed-off-by: Joe Elliott <number101010@gmail.com> * fix and tests Signed-off-by: Joe Elliott <number101010@gmail.com> * removed ancestor/descendant due to parsing issues Signed-off-by: Joe Elliott <number101010@gmail.com> * added tempodb lvl tests Signed-off-by: Joe Elliott <number101010@gmail.com> * parse tests Signed-off-by: Joe Elliott <number101010@gmail.com> * consolidated code Signed-off-by: Joe Elliott <number101010@gmail.com> * tests Signed-off-by: Joe Elliott <number101010@gmail.com> * docs Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * not ancestor/descendant Signed-off-by: Joe Elliott <number101010@gmail.com> * tempodb tests and docs Signed-off-by: Joe Elliott <number101010@gmail.com> * remove load Signed-off-by: Joe Elliott <number101010@gmail.com> * Apply suggestions from code review Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
!>,!>>,!<,!>>, and!~.Which issue(s) this PR fixes:
Fixes #1811
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]