Add per-tenant compaction window#3129
Merged
zalegrala merged 9 commits intografana:mainfrom Nov 14, 2023
Merged
Conversation
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
zalegrala
changed the title
zalegrala
requested review from
jdbaldry and
knylander-grafana
as code owners
joe-elliott
reviewed
Nov 13, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
is this referenceable using the old overrides config style? we might need it to be to used in our internal clusters since we haven't migrated forward.
Contributor
Author
|
The config is bi-directional, but you can chose only new or legacy at a time. I updated the round-trip test for this change. |
joe-elliott
reviewed
Nov 13, 2023
Collaborator
Good call. I see the code now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a
compaction_windowoverride to be used per-tenant. This will allow large and small tenants to scale the window independently and be a little more flexible.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]