[spanmetrics] Sanitize name in mapped dimensions#3171
Merged
mapno merged 5 commits intografana:mainfrom Nov 23, 2023
Merged
Conversation
mapno
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
yvrhdn
approved these changes
Nov 23, 2023
Contributor
yvrhdn
left a comment
yvrhdn
left a comment
There was a problem hiding this comment.
LGTM!
Since we are calling the sanitize function at multiple points, I wonder if we should move this into the registry? The registry could do it more centralized and we don't risk forgetting about it in the processors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
If not sanitized, Prometheus incompatible labels can be sent.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]