Skip to content

Add support for multi-tenant queries in streaming search#3262

Merged
electron0zero merged 19 commits intografana:mainfrom
electron0zero:mt_search_streaming
Jan 25, 2024
Merged

Add support for multi-tenant queries in streaming search#3262
electron0zero merged 19 commits intografana:mainfrom
electron0zero:mt_search_streaming

Conversation

@electron0zero
Copy link
Copy Markdown
Member

@electron0zero electron0zero commented Dec 26, 2023

What this PR does:

Add multi-tenant query support in streaming search endpoints.

follow up on #3087

Which issue(s) this PR fixes:
Fixes #1858

### Tasks
- [x] multi-tenant streaming Search works
- [x] test for multiProgress
- [x] fix metrics in streamed results
- [x] test that streaming actually streams

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@electron0zero electron0zero self-assigned this Jan 12, 2024
@electron0zero electron0zero force-pushed the mt_search_streaming branch 2 times, most recently from f7516bb to 6ed8107 Compare January 17, 2024 23:09
@electron0zero electron0zero marked this pull request as ready for review January 17, 2024 23:12
Comment thread example/docker-compose/multi-tenant/docker-compose.yaml
Comment thread integration/e2e/multi_tenant_test.go Outdated
Comment thread integration/e2e/multi_tenant_test.go Outdated
Comment thread integration/e2e/multi_tenant_test.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
Comment thread modules/frontend/search_streaming.go
@electron0zero electron0zero force-pushed the mt_search_streaming branch 2 times, most recently from b3369af to 18ae136 Compare January 18, 2024 21:48
@knylander-grafana
Copy link
Copy Markdown
Contributor

@electron0zero What would you think about adding a query example to the TraceQL page to demonstrate this new capability? Are there any configuration options that need to be updated?

Comment thread integration/e2e/multi_tenant_test.go Outdated
Comment thread modules/frontend/search_streaming.go
Comment thread modules/frontend/search_progress.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
Comment thread modules/frontend/search_streaming.go Outdated
@electron0zero
Copy link
Copy Markdown
Member Author

@electron0zero What would you think about adding a query example to the TraceQL page to demonstrate this new capability?

@knylander-grafana It will be transperent to user querying data and should work for all queries, and doesn't add anything new in TraceQL.

Are there any configuration options that need to be updated?

this is a follow up on #3087, and we documented config option in that PR, no updates now.

Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to search all tenants in multi-tenant setups

3 participants