Local blocks processor honor per-tenant max trace size#3305
Merged
mdisibio merged 6 commits intografana:mainfrom Jan 17, 2024
Merged
Local blocks processor honor per-tenant max trace size#3305mdisibio merged 6 commits intografana:mainfrom
mdisibio merged 6 commits intografana:mainfrom
Conversation
zalegrala
reviewed
Jan 17, 2024
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
A couple comments, but overall looks reasonable to me.
…variable name change, review comments
mdisibio
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
stoewer and
yvrhdn
as code owners
mdisibio
added a commit
to mdisibio/tempo
that referenced
this pull request
Jan 22, 2024
* Keep track of trace sizes for the lifetime of the headblock, add metrics * lint * Comment * Fix invalid assumption that all batches have the same trace id. Undo variable name change, review comments * changelog
mdisibio
added a commit
that referenced
this pull request
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the local-blocks processor to honor the per-tenant override
max_trace_bytes. The generators already make use of the per-tenant overrides but this field. This goes one step further than the trace size limits in the ingesters. The ingesters keep track of the historical trace size only for the lifetime of the headblock, and that means long-running traces can eventually append more data. This goes one step further and maintains the historical trace size for as long as the trace is active (continues to send spans).Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]