Skip to content

Fix 429s tripping SLOs#3469

Merged
joe-elliott merged 3 commits intografana:mainfrom
joe-elliott:429s-are-sad
Mar 6, 2024
Merged

Fix 429s tripping SLOs#3469
joe-elliott merged 3 commits intografana:mainfrom
joe-elliott:429s-are-sad

Conversation

@joe-elliott
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott commented Mar 6, 2024

What this PR does

  • Correctly translates "queue full" into a 429 for the http pipeline
  • Correctly propagates ResourceExhausted gRPC error instead of InvalidArgument
  • Correctly prevents 429s from counting against SLOs

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit ae083c3 into grafana:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants