Tempo: Refactor Trace By ID and Metrics Summary#3522
Merged
joe-elliott merged 22 commits intografana:mainfrom Apr 11, 2024
Merged
Tempo: Refactor Trace By ID and Metrics Summary#3522joe-elliott merged 22 commits intografana:mainfrom
joe-elliott merged 22 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Contributor
knylander-grafana
left a comment
There was a problem hiding this comment.
Doc updates look good. Thank you for updating the docs.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
yvrhdn
reviewed
Apr 11, 2024
Contributor
yvrhdn
left a comment
There was a problem hiding this comment.
LGTM overall 👍 Left some minor comments
yvrhdn
approved these changes
Apr 11, 2024
Contributor
yvrhdn
left a comment
There was a problem hiding this comment.
I'm fine with merging this 👍 just got some minor questions/issues, nothing blocking
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Refactors 2 more endpoints to use the new frontend pipeline items. The final one will be the new query range endpoint. Trace by ID was more difficult than expected. It has a few unique features that make it harder to work with:
Testing is looking good for no regressions.
Other changes:
Which issue(s) this PR fixes:
Works toward #3413
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]