Add metrics for bytes and objects written during compaction#360
Add metrics for bytes and objects written during compaction#360joe-elliott merged 10 commits intografana:masterfrom
Conversation
There was a problem hiding this comment.
Should we drop metricCompactionDuration? I feel like that metric loses it's meaning with the variable block compactions.
Also, what do you think about tempodb_compaction_blocks_total{level=''}. A counter that increments once for every processed block of each level. We could drop the duration histogram while still having some vision on which compactors are compacting blocks at which levels.
Oh, and feel free to add any of this to the operational dashboard that makes sense. I think there's a compaction section now.
Agree, added the level label and new metric, and added both new metrics to the operational dashboard. I am not 100% satisfied with I'm inclined to leave the duration metric for now, while we settle on the best KPIs for compaction. |
joe-elliott
left a comment
There was a problem hiding this comment.
A couple of final touches and it will be ready to merge. Also make sure to list the removed metric in the changelog. Thanks!
…objects_written metrics when flushing for efficiency
d942072 to
47d7f97
Compare
What this PR does:
Adds three new new metrics to track compaction performance and help estimate capacity. The metrics include a
levellabel which is the input compaction level.tempodb_compaction_objects_writtenandtempodb_compaction_bytes_writtenwhich are updated when the compactor flushes to the backend.tempodb_compaction_blocks_totalCount of input blocks compacted.Removes tempodb_compaction_duration_seconds metric as it is obsoleted by the new metrics.
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]