Fix Ingesters Occassionally Double Flushing#364
Merged
joe-elliott merged 14 commits intografana:masterfrom Nov 24, 2020
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
changed the title
joe-elliott
changed the title
Signed-off-by: Joe Elliott <number101010@gmail.com>
mdisibio
reviewed
Nov 23, 2020
mdisibio
reviewed
Nov 23, 2020
mdisibio
approved these changes
Nov 23, 2020
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
lgtm. A few minor comments mentioned, but more of just questions than recommendations.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
calvernaz
reviewed
Nov 24, 2020
Contributor
calvernaz
left a comment
calvernaz
left a comment
There was a problem hiding this comment.
LGTM, I just have a question regarding the clear operation.
Signed-off-by: Joe Elliott <number101010@gmail.com>
annanay25
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Occassionally ingesters fail to flush due to a double queuing (#217) issue discovered by @calvernaz. This PR looks to fix that by:
ExclusiveQueuesthat prevents multiple items from being queued with the same keyflushLoop()to either call.Requeue()or.ClearKey()after flush has failed or succeeded./pkg/util/teststopping()eep!Which issue(s) this PR fixes:
Fixes #217
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]