Skip to content

vParquet4: update opentelemetry-proto and add scope attrs#3649

Merged
stoewer merged 7 commits intografana:mainfrom
stoewer:vp4-update-otel-proto-and-links
May 9, 2024
Merged

vParquet4: update opentelemetry-proto and add scope attrs#3649
stoewer merged 7 commits intografana:mainfrom
stoewer:vp4-update-otel-proto-and-links

Conversation

@stoewer
Copy link
Copy Markdown
Contributor

@stoewer stoewer commented May 7, 2024

What this PR does:

Follow up changes that were not included in the original vParquet4 PR

  • Update the opentelemetry-proto to v1.3.0
    Breaking Change The update removes the deprecated InstrumentationLibrary and InstrumentationLibrarySpan from the OTLP receivers
  • Handle attributes for instrumentation scope correctly

Which issue(s) this PR fixes:
Contribute to grafana/tempo-squad#299

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@stoewer stoewer marked this pull request as ready for review May 8, 2024 05:42
Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update removes the deprecated instrumentation_library fields. I believe this is a breaking change for the gRPC API. It's been deprecated for over 2 years now, but I think we should still note it somewhere.

@stoewer stoewer changed the title vParquet4: update opentelemetry-proto and scope handle attrs vParquet4: update opentelemetry-proto and add scope attrs May 9, 2024
@stoewer stoewer merged commit 3f420b6 into grafana:main May 9, 2024
@stoewer stoewer deleted the vp4-update-otel-proto-and-links branch March 13, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants