Conversation
zalegrala
approved these changes
May 8, 2024
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
One comment, but looks good to me.
mdisibio
changed the title
mdisibio
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
stoewer and
yvrhdn
as code owners
|
this should REALLY be fixed in the docker distribution too! |
Contributor
|
@Enrice I'm not sure what you mean. Are you encountering an issue? |
|
My issue is that I would need to apply the workaround depicted in #3601 which I cannot do at the moment. |
Contributor
|
If you'd like to give us more information about your environment, we can help you work through the issue. Consider joining the community slack. I'm zleslie in there and would be happy to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The motivation for this PR is to fix the deb and rpm Drone test process, but we decided it's also a good improvement that should be shipped in the packages.
The deb and rpm packages install Tempo as a systemd service, under a newly-created user
tempo. However the services can't start out of the box because thetempouser lacks permissions to create and write to/var/tempowhich is the default storage path. This updates the post install process to create and assign perms to/var/tempo. Unfortunately we couldn't pin down when this became a problem or what changed.Note A tricky bit is that Drone only runs for tags and PRs of branches in the Tempo repo itself. If you PR is from a fork, it doesn't run. This made the failures go unnoticed for some time as most PRs are from forks.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]