Skip to content

👋 So long vParquet1, and thanks for all the fish!#3663

Merged
mdisibio merged 2 commits intografana:mainfrom
mdisibio:rm-vparquet1
May 9, 2024
Merged

👋 So long vParquet1, and thanks for all the fish!#3663
mdisibio merged 2 commits intografana:mainfrom
mdisibio:rm-vparquet1

Conversation

@mdisibio
Copy link
Copy Markdown
Contributor

@mdisibio mdisibio commented May 9, 2024

What this PR does:
In the last release vParquet (1) was deprecated, and now it's being deleted. It was good, but vParquet4 is 4x better.

Removal is straightforward except in tempo-cli. Two of the commands seemed obsolete and were removed (convert block, and convert parquet-1-to-2). A few others were trivially updated to point at vParquet3 which is the default encoding.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
Copy link
Copy Markdown
Collaborator

the linter refuses to let go:

image

Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7

@mdisibio mdisibio merged commit e06c339 into grafana:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants