feat: added new helper function to allow debugging e2e tests#3836
Merged
mapno merged 5 commits intografana:mainfrom Jul 4, 2024
Merged
feat: added new helper function to allow debugging e2e tests#3836mapno merged 5 commits intografana:mainfrom
mapno merged 5 commits intografana:mainfrom
Conversation
mapno
reviewed
Jul 3, 2024
Contributor
mapno
left a comment
There was a problem hiding this comment.
Would it be possible to include the user guide in the /integration readme?
mapno
reviewed
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It can be handy to debug Tempo code when running an e2e test. This can be done in different ways. This PR aims to ease this task by providing a new function to spin a Tempo docker container based on the tempo-debug image, without modifying any aspect of the test so it can be run in the same way either locally or in the CI.
Limitations:
I haven't found a way to expose the docker host port locally ie: -p 2345:2345.
This could be enhanced to allow that:
https://github.com/grafana/e2e/blob/db90b84177fccb4f023ea9f71ec0e8dcd2d3bdad/service.go#L328
How to use it:
The debug process is a bit cumbersome right now:
NewTempoAllInOnDebugto spin the debug containerChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]