chore: update mixin deps and add recording_rules_range_interval#3851
Merged
mapno merged 4 commits intografana:mainfrom Jul 11, 2024
Merged
Conversation
jmichalek132
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
|
|
jmichalek132
commented
Jul 9, 2024
mapno
reviewed
Jul 10, 2024
Contributor
mapno
left a comment
mapno
left a comment
There was a problem hiding this comment.
LGTM. Could you add a changelog entry?
jmichalek132
force-pushed
the
jm-chore-mixin-make-range-interval-configurable
branch
from
57cf4f1 to
d607c5b
Compare
auto-merge was automatically disabled
July 11, 2024 09:48
Head branch was pushed to by a user without write access
jmichalek132
force-pushed
the
jm-chore-mixin-make-range-interval-configurable
branch
from
d607c5b to
45c3a84
Compare
jmichalek132
force-pushed
the
jm-chore-mixin-make-range-interval-configurable
branch
from
45c3a84 to
a3f7452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
histogramRuleswhich allows specifying range_interval)recording_rules_range_intervalto allow overriding the range_interval in recording rules.Which issue(s) this PR fixes:
Fixes #3815
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]