Skip to content

chore: Adjust server-less tooling for the new AWS Lambda "provided" run-times#3852

Merged
mapno merged 8 commits intografana:mainfrom
zatlodan:patch-1
Oct 28, 2024
Merged

chore: Adjust server-less tooling for the new AWS Lambda "provided" run-times#3852
mapno merged 8 commits intografana:mainfrom
zatlodan:patch-1

Conversation

@zatlodan
Copy link
Copy Markdown
Contributor

@zatlodan zatlodan commented Jul 9, 2024 •
edited
Loading

What this PR does:

The "old" go1.x runtime is being deprecated.

Changes the CMD server-less build tooling to be compatible with the "new" AWS lambda run-times by default.

The "new" GoLang compatible AWS Lambda run-times expect an executable with the name bootstrap to be provided.
The handler configuration is ignored when using the "new" runtime.

See https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-from-the-go1-x-runtime-to-the-custom-runtime-on-amazon-linux-2/ for more info.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zatlodan zatlodan changed the title chore: Add compatibility with AWS lambda "provided" run-times chore: Add default compatibility with AWS lambda "provided" run-times Jul 9, 2024
@zatlodan zatlodan changed the title chore: Add default compatibility with AWS lambda "provided" run-times chore: Adjust server-less tooling for the new AWS Lambda "provided" run-times Jul 9, 2024
mapno
mapno reviewed Jul 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Can you add a changelog entry specifying what's being deprecated? Thanks!

@zatlodan
Copy link
Copy Markdown
Contributor Author

zatlodan commented Jul 15, 2024

LGMT. Can you add a changelog entry specifying what's being deprecated? Thanks!

Thank you, and sorry for the late response.

I've added a changelog entry.
Since this change only affects the build tooling, I didn't mark it as a breaking change,
although it might require adjustments for users relying on the previous build process.

Please let me know if any further adjustments are needed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2024

This PR has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. This pull request will be closed in 15 days if there is no new activity.
Please apply keepalive label to exempt this Pull Request.

@github-actions github-actions Bot added the stale Used for stale issues / PRs label Sep 14, 2024
@zatlodan zatlodan requested a review from mapno September 14, 2024 00:30
@github-actions github-actions Bot removed the stale Used for stale issues / PRs label Sep 15, 2024
mapno
mapno reviewed Sep 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to be a bit more explicit with the migration.

Comment thread CHANGELOG.md Outdated
@zatlodan @mapno
Update CHANGELOG.md
6632f21 
Co-authored-by: Mario <mariorvinas@gmail.com>
@zatlodan zatlodan requested a review from mapno September 16, 2024 12:23
@zatlodan
Copy link
Copy Markdown
Contributor Author

zatlodan commented Sep 16, 2024

I'd like to be a bit more explicit with the migration.

I agree, it is better to be more explicit here.
I was initially not sure if I should mark it as a breaking change, as I am not used to writing change-logs.

@zatlodan
Copy link
Copy Markdown
Contributor Author

zatlodan commented Oct 28, 2024

@mapno Can we get an update on this?

@mapno
Copy link
Copy Markdown
Contributor

mapno commented Oct 28, 2024

LGTM, thanks for the contribution

@mapno mapno enabled auto-merge (squash) October 28, 2024 11:52
@mapno mapno merged commit 1f12bd2 into grafana:main Oct 28, 2024
knylander-grafana pushed a commit that referenced this pull request Oct 29, 2024
@zatlodan @mapno @knylander-grafana
chore: Adjust server-less tooling for the new AWS Lambda "provided" r…
597fb24 
…un-times (#3852)

* chore: compatibility with AWS lambda new runtime

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Mario <mariorvinas@gmail.com>

* doc: remove additional newline

---------

Co-authored-by: Mario <mariorvinas@gmail.com>
@electron0zero electron0zero mentioned this pull request Nov 28, 2024
Closed
@electron0zero electron0zero mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mapno mapno mapno approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott

@annanay25 annanay25 Awaiting requested review from annanay25

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zatlodan @CLAassistant @mapno