Fix poller to maintain previous blocklist results on tenant error#3860
Merged
zalegrala merged 2 commits intografana:mainfrom Jul 12, 2024
Merged
Conversation
mdisibio
approved these changes
Jul 12, 2024
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Yep this fixes my issue locally 👍
zalegrala
force-pushed
the
fixBlocklistResultsOnErrorCondition
branch
from
aa42bff to
a2c2390
Compare
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
stoewer and
yvrhdn
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we fix a bug where a single tenant experiences an error during polling,
which is not enough to trip the max error threshold. In this case, the tenant
which experienced the error would be removed from the blocklist, and would not
be re-added until the next time the poller runs. Inconsistent results in the
blocklist can cause issues on the query path for this tenant.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]