feat: expose availability-zone as a cli flag for ingester#3881
Merged
joe-elliott merged 6 commits intografana:mainfrom Jul 19, 2024
Merged
feat: expose availability-zone as a cli flag for ingester#3881joe-elliott merged 6 commits intografana:mainfrom
joe-elliott merged 6 commits intografana:mainfrom
Conversation
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
KyriosGN0
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
|
|
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
joe-elliott
reviewed
Jul 18, 2024
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
zalegrala
reviewed
Jul 19, 2024
joe-elliott
approved these changes
Jul 19, 2024
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
expose availability-zone cli flag (needed for zone aware ingester in helm chart)
Which issue(s) this PR fixes:
Fixes #3877
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]