Query-frontend: Performance Improvements and Refactor#3888
Merged
joe-elliott merged 11 commits intografana:mainfrom Jul 23, 2024
Merged
Query-frontend: Performance Improvements and Refactor#3888joe-elliott merged 11 commits intografana:mainfrom
joe-elliott merged 11 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
mapno
reviewed
Jul 23, 2024
Contributor
mapno
left a comment
There was a problem hiding this comment.
Refactor looks OK. Any idea why this is faster or uses less memory?
| // - adds the tenant header | ||
| // - sets the requesturi (see below for details) | ||
| func prepareRequestForQueriers(req *http.Request, tenant string, originalURI string, params url.Values) { | ||
| func prepareRequestForQueriers(req *http.Request, tenant string) { |
Contributor
There was a problem hiding this comment.
I find this function pretty obscure. Why don't we return a new http.Request based on the original one?
func getQuerierHTTPRequest(origin_req *http.Request, tenant string) *http.Request{
}That way we will reduce the cognitive overload reading the code
Collaborator
Author
There was a problem hiding this comment.
I would prefer modifying in place to reduce allocs
Collaborator
Author
I removed these calls to I have a follow up PR coming that will remove millions of these calls from the search path. |
mapno
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Refactors the frontend to pass a
Requestinterface instead of an*http.Request. This is progress toward supporting deterministic search. Also added a search pipeline benchmark and found a perf improvement inprepareRequestForQueriers.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]