Drop MinID/MaxID from BlockMeta#3950
Merged
zalegrala merged 2 commits intografana:mainfrom Aug 9, 2024
Merged
Conversation
zalegrala
force-pushed
the
blockMetaMinMax
branch
3 times, most recently
from
ac98dde to
3889306
Compare
To shrink the size of the BlockMeta, here we drop two fields that should have very little overall impact due to their light use.
zalegrala
force-pushed
the
blockMetaMinMax
branch
from
3889306 to
24924ca
Compare
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
joe-elliott
reviewed
Aug 9, 2024
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
changelog? i feel like you have a few coming, maybe just one changelog entry for all?
Contributor
Author
|
I'll add to that changelog entry on the other PRs. |
joe-elliott
approved these changes
Aug 9, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
To shrink the size of the BlockMeta, here we drop two fields that should have very little overall impact due to their light use.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]