feat: added new middleware to validate request query values#3993
Merged
joe-elliott merged 4 commits intografana:mainfrom Aug 22, 2024
Merged
feat: added new middleware to validate request query values#3993joe-elliott merged 4 commits intografana:mainfrom
joe-elliott merged 4 commits intografana:mainfrom
Conversation
javiermolinar
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
joe-elliott
reviewed
Aug 22, 2024
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
nice! let's add a simple e2e test to confirm we get a 400 back.
nit: rename query_validator_middleware.go to async_query_validator.go to match the other async pipeline items
Contributor
Author
|
I clicked on close by mistake :P |
joe-elliott
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It adds a new middleware to centralize query validations. For now, it checks if a traceQL is valid. If not it returns a 400 error code.
For metrics_query_range and metrics_query the validation is done before the middleware is executed since it's required to compile the TraceQL query to create the combiner. In these two places, we can switch from a 500 error code to a 400 one.
Which issue(s) this PR fixes:
Fixes #3990
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]