GRPC Streaming: Send diff instead of full response#4062
Merged
joe-elliott merged 3 commits intografana:mainfrom Sep 6, 2024
Merged
GRPC Streaming: Send diff instead of full response#4062joe-elliott merged 3 commits intografana:mainfrom
joe-elliott merged 3 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
electron0zero,
ie-pham,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
electron0zero
approved these changes
Sep 6, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change impacts all streaming endpoints. Instead of returning a complete final message this has the query frontend send only a final diff. For searches with very large limits and span limits we were seeing enormous final messages returned to Grafana which tripped a limit in their websocket implementation.
The initial intention of sending the final message was to make sure the frontend got a complete response in case one of the intermediate messages was lost due to a bug. This seems to be unlikely and the rare case it does happen is not worth the cost of always sending the full response all the time.
cc @adrapereira
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]