feat: TraceQL metrics: average over time#4073
Merged
javiermolinar merged 31 commits intografana:mainfrom Oct 31, 2024
Merged
Conversation
javiermolinar
commented
Sep 12, 2024
javiermolinar
commented
Sep 12, 2024
javiermolinar
commented
Sep 12, 2024
javiermolinar
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
Contributor
|
Not sure if I'm reading this right, but it looks like it's computing the average at each level. I was expecting |
javiermolinar
commented
Oct 17, 2024
javiermolinar
commented
Oct 17, 2024
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding doc! Approving the doc, with two minor suggestions. Please be aware that this PR updates the metrics queries doc: #4128
mdisibio
approved these changes
Oct 31, 2024
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Thanks for the last round of changes. This is looking great.
knylander-grafana
approved these changes
Oct 31, 2024
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Approving the doc changes. Thank you for updating!
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It implements the avg_over_time aggregation function
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]