Skip to content

Update otelhttp to fix regression#4149

Merged
zalegrala merged 3 commits intografana:mainfrom
zalegrala:otelUpdateForRegression
Oct 2, 2024
Merged

Update otelhttp to fix regression#4149
zalegrala merged 3 commits intografana:mainfrom
zalegrala:otelUpdateForRegression

Conversation

@zalegrala
Copy link
Copy Markdown
Contributor

What this PR does:
Tempo is affected by the change here.
https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6055/files

Logging a considerable amount of the following.

http: superfluous response.WriteHeader call from go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/request.(*RespWriterWrapper).writeHeader (resp_writer_wrapper.go:78)

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala merged commit e101d24 into grafana:main Oct 2, 2024
@zalegrala zalegrala deleted the otelUpdateForRegression branch October 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants