fix: skip exemplars for instant queries#4204
Conversation
javiermolinar
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
|
Can we live without this config? tempo/modules/frontend/config.go Line 96 in 280128f If |
This sounds good to me. @mapno You originally implemented this, can you think of a scenario where max_exemplars=0 and exemplars=true is meaningful? |
Co-authored-by: Martin Disibio <mdisibio@gmail.com>
Can't think of one. Possible was left from a previous implementation. I'm good to remove it. |
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for updating the docs. The updates look good.
fix: skip exemplars for instant queries (#4204) Currently, we are computing the exemplars for query_range and instant queries. Since exemplars are not supported for instant queries (same as Prometheus) we can save that computing time. It also fixes a bug where the exemplars query param was not being honored Co-authored-by: Martin Disibio <mdisibio@gmail.com>
4 participants
What this PR does:
Currently, we are computing the exemplars for
query_rangeandinstant queries. Since exemplars are not supported for instant queries (same as Prometheus) we can save that computing time.It also fix a bug where the
exemplarsquery param was not being honoredChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]