Skip to content

Query-Frontend: Perf improvements#4242

Merged
joe-elliott merged 12 commits intografana:mainfrom
joe-elliott:drop-headers
Nov 1, 2024
Merged

Query-Frontend: Perf improvements#4242
joe-elliott merged 12 commits intografana:mainfrom
joe-elliott:drop-headers

Conversation

@joe-elliott
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott commented Oct 28, 2024 •
edited
Loading

What this PR does:

Some small perf improvements and cleanup noticed while working on the ordered results PR.

  • Use our ReadAllWithEstimate() instead of io.ReadAll().
  • Standardized the way we clone child requests and dropped unnecessary headers.
  • Standardized our response logging. We were using both "results" and "response" so i picked one.
  • Pre-alloc 100 bytes on the query builder slice

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott joe-elliott marked this pull request as ready for review October 28, 2024 18:44
javiermolinar
javiermolinar reviewed Oct 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Comment thread modules/frontend/frontend.go Outdated
Comment thread modules/frontend/metrics_query_range_sharder.go Outdated
Comment thread modules/frontend/metrics_query_range_sharder.go Outdated
Comment thread modules/frontend/search_sharder.go
Comment thread modules/frontend/tag_sharder.go
Comment thread modules/frontend/tag_sharder.go
Comment thread modules/frontend/traceid_sharder.go Outdated
javiermolinar
javiermolinar reviewed Oct 31, 2024
View reviewed changes
Comment thread modules/frontend/traceid_sharder.go
javiermolinar
javiermolinar approved these changes Oct 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@joe-elliott
create and use a way to consistently clone requests
6d9ce6f 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
use content len
11b07d2 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
fix tests
1280361 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
standardize logging
1922e9e 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
cleanup
8b74818 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
i love the linter
c5f76ff 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
lint
fb3fa0e 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
prealloc builder
ffb2351 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
changelog
4fbf307 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
do what the comment says so CI passes
02eb410 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
review
4730c54 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
add tracing context to pipeline request
30c34a7 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 44c18cc into grafana:main Nov 1, 2024
@mapno mapno mentioned this pull request Nov 5, 2024
Merged
3 tasks
@electron0zero electron0zero mentioned this pull request Nov 28, 2024
Closed
@electron0zero electron0zero mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiermolinar javiermolinar javiermolinar approved these changes

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joe-elliott @javiermolinar