Prealloc tweaks#4369
Merged
joe-elliott merged 6 commits intografana:mainfrom Nov 26, 2024
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
…tly failing Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
electron0zero,
ie-pham,
javiermolinar,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
zalegrala
approved these changes
Nov 25, 2024
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
Looks good to me. Nice one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
#4344 improved prealloc behavior gettings us 10-40% working set reductions across all our clusters. It also introduced a metric to help track prealloc "misses". This PR by default will not change any Tempo behavior but will give better information and tunable parameters for precise tuning of the prealloc buckets.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]